Move rules and other build definitions into their own public files and deprecate the umbrella swift.bzl file
#1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
referenced
this pull request
Jun 19, 2024
…d deprecate the umbrella `swift.bzl` file. Aside from the file moves, this required some minor shuffling of definitions in a few files that contains both internal and external defs, to ensure that more wasn't exported than intended. This change doesn't delete `swift.bzl` yet; follow-up changes will update `load` statements that reference it directly first. PiperOrigin-RevId: 449274280
brentleyjones
force-pushed
the
bj/cp-57cdd762d4b2e49311c4595b6e1149fef553cfef
branch
from
b02da88
to
b028087
Compare
|
In a follow-up PR I'll do the same for the stuff in |
brentleyjones
force-pushed
the
bj/cp-57cdd762d4b2e49311c4595b6e1149fef553cfef
branch
2 times, most recently
from
deb2e83
to
835c13b
Compare
…d deprecate the umbrella `swift.bzl` file. Aside from the file moves, this required some minor shuffling of definitions in a few files that contains both internal and external defs, to ensure that more wasn't exported than intended. This change doesn't delete `swift.bzl` yet; follow-up changes will update `load` statements that reference it directly first. PiperOrigin-RevId: 449274280 (cherry picked from commit 57cdd76) Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
force-pushed
the
bj/cp-57cdd762d4b2e49311c4595b6e1149fef553cfef
branch
from
835c13b
to
f4f1617
Compare
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
thii
approved these changes
Jun 20, 2024
luispadron
reviewed
Jun 20, 2024
Comment on lines
+10
to
+19
| "/swift:providers", | ||
| "/swift/internal:actions", | ||
| "/swift/internal:attrs", | ||
| "/swift/internal:autolinking", | ||
| "/swift/internal:compiling", | ||
| "/swift/internal:debugging", | ||
| "/swift/internal:feature_names", | ||
| "/swift/internal:features", | ||
| "/swift/internal:toolchain_config", | ||
| "/swift/internal:utils", |
There was a problem hiding this comment.
This broke bazel build //... because of /swift:
ERROR: /Users/luispadron/Development/rules_swift/swift/toolchains/BUILD:5:12: //swift/toolchains:swift_toolchain: invalid label '/swift:providers' in element 0 of attribute 'deps' in 'bzl_library' rule: invalid package name '/swift': package names may not start with '/'
ERROR: /Users/luispadron/Development/rules_swift/swift/toolchains/BUILD:26:12: //swift/toolchains:xcode_swift_toolchain: invalid label '/swift/internal:actions' in element 0 of attribute 'deps' in 'bzl_library' rule: invalid package name '/swift/internal': package names may not start with '/'
ERROR: package contains errors: swift/toolchains
ERROR: package contains errors: swift/toolchains: //swift/toolchains:swift_toolchain: invalid label '/swift:providers' in element 0 of attribute 'deps' in 'bzl_library' rule: invalid package name '/swift': package names may not start with '/'
WARNING: Target pattern parsing failed.
ERROR: Skipping '//...': Error evaluating '//...': error loading package 'swift/toolchains': Package 'swift/toolchains' contains errors
ERROR: Error evaluating '//...': error loading package 'swift/toolchains': Package 'swift/toolchains' contains errors
INFO: Elapsed time: 0.104s
INFO: 0 processes.
ERROR: Build did NOT complete successfullyThere was a problem hiding this comment.
Thanks. I'll fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from the file moves, this required some minor shuffling of definitions in a few files that contains both internal and external defs, to ensure that more wasn't exported than intended.
This change doesn't delete
swift.bzlyet; follow-up changes will updateloadstatements that reference it directly first.PiperOrigin-RevId: 449274280
(cherry picked from commit 57cdd76)