-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Swift compiler sandboxing in Xcode 15.3+ to fix nested sandboxing #1206
Disable Swift compiler sandboxing in Xcode 15.3+ to fix nested sandboxing #1206
Conversation
b6724dd
to
7db5d24
Compare
Is it possible to add a test case as well for this, would catch regressions in the future |
Signed-off-by: Adin Cebic <cebic.ad@gmail.com>
7db5d24
to
be3196b
Compare
@luispadron No reason not to, just need to learn how to write tests in Starlark :) |
Co-authored-by: Brentley Jones <github@brentleyjones.com>
Signed-off-by: Adin Cebic <cebic.ad@gmail.com>
@luispadron I added the test though it is not that comprehensive. Maybe a better integration test would be to add example project with SwiftUI preview macro and build that on CI down the road. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing up and addressing comments!
Is this fixed in 15.4? |
@keith tested in the reproducer @adincebic provided but looks like its still broken unless we disable_sandbox:
|
We use -load-plugin-library instead of executable, it works well, without the sandboxing issue |
This should solve #1202
and #1204
I am not sure whether this flag is required on Linux too.