Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker swiftc actions are missing standard error #640

Closed
jerrymarino opened this issue Jun 9, 2021 · 4 comments · Fixed by #642
Closed

worker swiftc actions are missing standard error #640

jerrymarino opened this issue Jun 9, 2021 · 4 comments · Fixed by #642

Comments

@jerrymarino
Copy link
Contributor

When I hit an error in a swift compiler action, standard error is gone.

FWIW: to help narrow this down, I have fixed the bug by reverting:
#633
and
#634
@jerrymarino jerrymarino changed the title worker is missing standard error worker swiftc actions are missing standard error Jun 9, 2021
@jerrymarino jerrymarino mentioned this issue Jun 9, 2021
Closed
@brentleyjones
Copy link
Collaborator

Thanks. I'll see what I messed up there.

jerrymarino added a commit to bazel-ios/rules_ios that referenced this issue Jun 9, 2021
@jerrymarino
[HOLD] Workaround stderr bug rules_swift
bd92f2a 
Workaround for bazelbuild/rules_swift#640

Fixes #252
@jerrymarino jerrymarino mentioned this issue Jun 9, 2021
Merged
@jerrymarino
Copy link
Contributor Author

@brentleyjones ah thanks for looking into it! For now, I've just reverted these in the fork really looking forward to the new feature though 👍

@brentleyjones
Copy link
Collaborator

Fixed by #642.

@brentleyjones brentleyjones linked a pull request Jun 10, 2021 that will close this issue
Fix worker based error reporting for WMO #642
Merged
@jerrymarino jerrymarino mentioned this issue Jun 10, 2021
Merged
@jerrymarino
Copy link
Contributor Author

@brentleyjones thanks for the quick fix ❤️ ! I'm going to test this out a bit this morning on rules_ios as well

jerrymarino added a commit to bazel-ios/rules_ios that referenced this issue Jun 10, 2021
@jerrymarino
Workaround stderr bug rules_swift (#253)
e2217af 
Workaround stderr bug rules_swift

Workaround for bazelbuild/rules_swift#640

Fixes #252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix worker based error reporting for WMO bazelbuild/rules_swift
2 participants
@brentleyjones @jerrymarino