Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
Simplify action configuration.
  • Loading branch information
mjburghard committed May 23, 2024
1 parent 2b542bf commit cbf6320
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions swift/internal/compiling.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -262,11 +262,7 @@ def compile_action_configs(
configurators = [
swift_toolchain_config.add_arg("-emit-bc"),
],
features = [
[SWIFT_FEATURE_EMIT_BC],
[SWIFT_FEATURE_FULL_LTO],
[SWIFT_FEATURE_THIN_LTO],
],
features = [SWIFT_FEATURE_EMIT_BC],
),

# Add the single object file or object file map, whichever is needed.
Expand Down Expand Up @@ -414,15 +410,13 @@ def compile_action_configs(
swift_toolchain_config.add_arg("-lto=llvm-thin"),
],
features = [SWIFT_FEATURE_THIN_LTO],
not_features = [SWIFT_FEATURE_FULL_LTO],
),
swift_toolchain_config.action_config(
actions = [swift_action_names.COMPILE],
configurators = [
swift_toolchain_config.add_arg("-lto=llvm-full"),
],
features = [SWIFT_FEATURE_FULL_LTO],
not_features = [SWIFT_FEATURE_THIN_LTO],
),
]

Expand Down

0 comments on commit cbf6320

Please sign in to comment.