Skip to content

Commit

Permalink
Address the rest of the feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
aaronsky authored and brentleyjones committed Apr 5, 2024
1 parent 61d5a1a commit 57d25f1
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 7 deletions.
2 changes: 0 additions & 2 deletions .bazelci/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,9 @@ tasks:
build_flags:
# Bazel 6.x has dependencies that produce warnings now
- "--features=-treat_warnings_as_errors"
- "--experimental_enable_aspect_hints"
test_flags:
# Bazel 6.x has dependencies that produce warnings now
- "--features=-treat_warnings_as_errors"
- "--experimental_enable_aspect_hints"

macos_latest:
name: "Current LTS"
Expand Down
5 changes: 5 additions & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ build --macos_minimum_os=13.0
# dependencies cause us to use a newer version
build --check_direct_dependencies=off

# This is needed for Bazel 6 compatibility. It is enabled by default in Bazel 7, so
# TODO: Remove this once we drop Bazel 6 support.
# See also: https://github.com/bazelbuild/bazel/issues/14327
build --experimental_enable_aspect_hints

# Make sure no warnings slip into the C++ tools we vendor
build --features treat_warnings_as_errors

Expand Down
2 changes: 0 additions & 2 deletions swift/internal/compiling.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -1592,8 +1592,6 @@ def _collect_clang_module_inputs(
# use include scanning from Starlark, we can't compute a more
# precise input set.
compilation_context = clang_module.compilation_context
if not compilation_context:
continue
transitive_inputs.append(compilation_context.headers)
transitive_inputs.append(
depset(compilation_context.direct_textual_headers),
Expand Down
4 changes: 1 addition & 3 deletions swift/internal/swift_clang_module_aspect.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -587,9 +587,7 @@ def _handle_module(
else:
return []

compilation_contexts_to_merge_for_compilation = []
if compilation_context:
compilation_contexts_to_merge_for_compilation.append(compilation_context)
compilation_contexts_to_merge_for_compilation = [compilation_context]

# Fold the `strict_includes` from `apple_common.Objc` into the Clang module
# descriptor in `SwiftInfo` so that the `Objc` provider doesn't have to be
Expand Down

0 comments on commit 57d25f1

Please sign in to comment.