-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
final phase is inlined #947
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -170,6 +170,7 @@ def _phase_compile( | |
java_jar = out.java_jar, | ||
source_jars = _pack_source_jars(ctx) + out.source_jars, | ||
merged_provider = out.merged_provider, | ||
external_providers = [out.merged_provider] + out.coverage.providers, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks like a duplicate from |
||
) | ||
|
||
def _compile_or_empty( | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
# | ||
# PHASE: default_info | ||
# | ||
# DOCUMENT THIS | ||
# | ||
def phase_binary_default_info(ctx, p): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as in #948:
|
||
return struct( | ||
external_providers = [ | ||
DefaultInfo( | ||
executable = p.declare_executable, | ||
files = depset([p.declare_executable] + p.compile.full_jars), | ||
runfiles = p.runfiles.runfiles, | ||
), | ||
], | ||
) | ||
|
||
def phase_library_default_info(ctx, p): | ||
return struct( | ||
external_providers = [ | ||
DefaultInfo( | ||
files = depset(p.compile.full_jars), | ||
runfiles = p.runfiles.runfiles, | ||
), | ||
], | ||
) | ||
|
||
def phase_scalatest_default_info(ctx, p): | ||
return struct( | ||
external_providers = [ | ||
DefaultInfo( | ||
executable = p.declare_executable, | ||
files = depset([p.declare_executable] + p.compile.full_jars), | ||
runfiles = ctx.runfiles(p.coverage_runfiles.coverage_runfiles, transitive_files = p.runfiles.runfiles.files), | ||
), | ||
], | ||
) |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here,
phase_compile.bzl
is usingjars2labels
, but we also putjars2labels
inexternal_providers
. Can we simplify it?