Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resource_strip_prefix of scala_libary for external repositories #944

Merged
merged 7 commits into from
Jan 21, 2020
Merged

Fix resource_strip_prefix of scala_libary for external repositories #944

merged 7 commits into from
Jan 21, 2020

Commits on Jan 20, 2020

  1. Fix resource_strip_prefix of scala_libary for external repositories 

    If repository `A` has a `scala_library` with `resources` and
`resource_strip_prefix` on which repository `B` depends then repository
`B` fails to build complaining that resource doesn't start with correct
prefix
    @simuons
    simuons committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    568c90c View commit details
    Browse the repository at this point in the history

  2. Push prefix handling down to _adjust_resources_path_by_strip_prefix 

    Use skylib to concat paths
    @simuons
    simuons committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    cdfcb1f View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2020

  1. Rewrite test with the external repo 

    This reflects situation described in PR
    @simuons
    simuons committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    edafc20 View commit details
    Browse the repository at this point in the history

  2. Run buildifier

    @simuons
    simuons committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    f2f7167 View commit details
    Browse the repository at this point in the history

  3. Revert external repository

    @simuons
    simuons committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    c072e45 View commit details
    Browse the repository at this point in the history

  4. Revrite test with local_repository

    @simuons
    simuons committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    5e4db43 View commit details
    Browse the repository at this point in the history

  5. Revert visiblity of scala_library

    @simuons
    simuons committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    e609c2d View commit details
    Browse the repository at this point in the history