Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat core files [split from code coverage PR] #707

Merged
merged 1 commit into from
Mar 1, 2019

Conversation

andyscott
Copy link
Contributor

This applies the formatting changes from Emacs' bazel-mode, in preparation for #692.

Copy link
Member

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for breaking this out. I should set up some formatting tool...

@johnynek
Copy link
Member

johnynek commented Mar 1, 2019

I’ll merge this when green then we can rebase the code coverage PR on it and it should be easier for @ittaiz to review.

@ittaiz
Copy link
Member

ittaiz commented Mar 1, 2019

Thanks! This will indeed make it much easier.
I've been reviewing several PRs lately (in other repos as well) that mix them and it adds significant cognitive overload

@ittaiz ittaiz merged commit 3703248 into bazelbuild:master Mar 1, 2019
gergelyfabian pushed a commit to gergelyfabian/rules_scala that referenced this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants