Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exec transition to scala_test _lcov_merger #1474

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Add exec transition to scala_test _lcov_merger #1474

merged 1 commit into from
Feb 27, 2023

Conversation

thirtyseven
Copy link
Contributor

@thirtyseven thirtyseven commented Feb 25, 2023 •
edited
Loading

Description

Have _lcov_merger run in the exec configuration. This fixes issues when running coverage when --java_runtime_version is a JRE 8 on Bazel > 6.x, similar to bazelbuild/bazel#17568.

Motivation

Fixes coverage on JRE 8.

@thirtyseven
Copy link
Contributor Author

thirtyseven commented Feb 25, 2023 •
edited
Loading

It looks like the failing test is also failing on nightly so probably unrelated to this change. Nvm, just realized it's the optional build on latest_green Bazel.

liucijus
liucijus approved these changes Feb 26, 2023
View reviewed changes
Copy link
Collaborator

@liucijus liucijus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @thirtyseven!

@liucijus liucijus merged commit 67b689d into bazelbuild:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simuons simuons simuons approved these changes

@liucijus liucijus liucijus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thirtyseven @simuons @liucijus