Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete dead code from ProtoReporter #1270

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

cocreature
Copy link
Contributor

@cocreature cocreature commented May 25, 2021

Description

Deletes a bunch of dead code.

Motivation

It’s not used anywhere.

Noticed that this wasn’t actually used anywhere while porting it to
Scala 3.
@simuons
Copy link
Collaborator

simuons commented May 27, 2021

@andrefmrocha you have added this code as part of #1068 but PR bazelbuild/bazel#11766 for which this code was added is stuck.
Do we still need to keep this code around? Are there any plans to progress with bazelbuild/bazel#11766?

@SocksDevil
Copy link
Contributor

@andrefmrocha you have added this code as part of #1068 but PR bazelbuild/bazel#11766 for which this code was added is stuck.
Do we still need to keep this code around? Are there any plans to progress with bazelbuild/bazel#11766?

Unfortunately I've had very little feedback on bazelbuild/bazel#11766, even after various attempts to reach out. So I think it's okay to remove it.

@SocksDevil
Copy link
Contributor

However, the ProtoReporter's output as a whole is already being used in bazel-bsp, so I hope we can maintain that

@cocreature
Copy link
Contributor Author

However, the ProtoReporter's output as a whole is already being used in bazel-bsp, so I hope we can maintain that

absolutely, I’m not trying to get rid of the proto output. Just of code that isn’t contributing to producing the output.

Copy link
Collaborator

@simuons simuons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andrefmrocha, I just wanted to know there is nothing planned for this code in near future.

@cocreature thanks for PR. LGTM.

@simuons simuons merged commit 2b7edf7 into bazelbuild:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants