Fix test target on macOS with Bazel@HEAD #558
Conversation
|
/cc @UebelAndre Can you take a look, this helps fix downstream breakage with Bazel@HEAD |
There was a problem hiding this comment.
You will also need to remove the section from .bazelrc/presubmit.yaml disabling these tests on MacOS so we can confirm the changes actually fixed the issue:
rules_rust/.bazelci/presubmit.yml
Lines 32 to 34 in 215a8de
When I build locally on your branch, I run into the following error
ERROR: /private/var/tmp/_bazel_user/4affd8360c36081ca80c76cb4d709ed4/external/local_libstdcpp/BUILD.bazel:3:11: SolibSymlink _solib_darwin_x86_64/_U@local_Ulibstdcpp_S_S_Clibstdc++___U/libstdc++.6.dylib failed: missing input file 'external/local_libstdcpp/libstdc++.6.dylib', owner: '@local_libstdcpp//:libstdc++.6.dylib'
ERROR: /private/var/tmp/_bazel_user/4affd8360c36081ca80c76cb4d709ed4/external/local_libstdcpp/BUILD.bazel:3:11 SolibSymlink _solib_darwin_x86_64/_U@local_Ulibstdcpp_S_S_Clibstdc++___U/libstdc++.6.dylib failed: 1 input file(s) do not exist
I'm wondering if CI will show the same.
But super thanks for attempting to tackle this issue! I'd love to see all tests working 😄
| @@ -20,9 +20,9 @@ cc_test( | |||
|
|
|||
| ## Do the same as above, but with a dynamic c library. | |||
|
|
|||
| cc_library( | |||
| cc_import( | |||
There was a problem hiding this comment.
Can you also update the load statement to include cc_import?
|
Also wondering if #226 is related to this |
|
#226 seems to be a different issue as this change was only made recently: bazelbuild/bazel@ec55533 |
|
@UebelAndre I think those tests are disabled for other issues this PR isn't aimed to fix. |
Avoid build artifacts name conflict after
supports_dynamic_linkerfeature was removed from cc toolchain for macOSContext: bazelbuild/bazel#4341 (comment)