Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary external dependencies #3088

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Dec 12, 2024

Addresses some failures identified in #3077

@UebelAndre UebelAndre force-pushed the cleanup branch 2 times, most recently from 3175132 to 389bf8d Compare December 12, 2024 05:17
@UebelAndre
Copy link
Collaborator Author

E.g. https://buildkite.com/bazel/rules-rust-rustlang/builds/13191#0193b2c6-8dc8-4b16-899b-d6e0d2e8070e

(22:53:23) ERROR: Skipping '//...': error loading package under directory '': error loading package '': Unable to find package for @@[unknown repo 'aspect_bazel_lib' requested from @@]//lib:transitions.bzl: The repository '@@[unknown repo 'aspect_bazel_lib' requested from @@]' could not be resolved: No repository visible as '@aspect_bazel_lib' from main repository. Was the repository introduced in WORKSPACE? The WORKSPACE file is disabled by default in Bazel 8 (late 2024) and will be removed in Bazel 9 (late 2025), please migrate to Bzlmod. See https://bazel.build/external/migration.
(22:53:23) ERROR: error loading package under directory '': error loading package '': Unable to find package for @@[unknown repo 'aspect_bazel_lib' requested from @@]//lib:transitions.bzl: The repository '@@[unknown repo 'aspect_bazel_lib' requested from @@]' could not be resolved: No repository visible as '@aspect_bazel_lib' from main repository. Was the repository introduced in WORKSPACE? The WORKSPACE file is disabled by default in Bazel 8 (late 2024) and will be removed in Bazel 9 (late 2025), please migrate to Bzlmod. See https://bazel.build/external/migration.

This directory probably should have bzlmod but I think reducing dependencies only used for small things is a good thing to do.

@UebelAndre UebelAndre force-pushed the cleanup branch 4 times, most recently from d631f90 to 337a768 Compare December 12, 2024 16:44
@UebelAndre UebelAndre marked this pull request as ready for review December 12, 2024 16:55
@UebelAndre UebelAndre enabled auto-merge December 12, 2024 16:55
@UebelAndre UebelAndre added this pull request to the merge queue Dec 13, 2024
Merged via the queue into bazelbuild:main with commit ba49599 Dec 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants