Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use abs from utils instead of the global #3075

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

avdv
Copy link
Contributor

@avdv avdv commented Dec 10, 2024

Fixes #3068

@avdv avdv force-pushed the cb/fix-abs-issue-3068 branch from 346510c to 48ca1ab Compare December 10, 2024 15:30
cargo/private/cargo_utils.bzl Outdated Show resolved Hide resolved
@avdv avdv force-pushed the cb/fix-abs-issue-3068 branch from da08f5f to 10a3d3c Compare December 12, 2024 09:44
@avdv avdv force-pushed the cb/fix-abs-issue-3068 branch from f14eb62 to 365dd21 Compare December 12, 2024 09:53
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me as a convenience for folks, but FYI we already don't support Bazel 6 :)

cargo/private/cargo_utils.bzl Show resolved Hide resolved
@illicitonion illicitonion added this pull request to the merge queue Dec 12, 2024
Merged via the queue into bazelbuild:main with commit ca827dd Dec 12, 2024
4 checks passed
@avdv
Copy link
Contributor Author

avdv commented Dec 13, 2024

Works for me as a convenience for folks, but FYI we already don't support Bazel 6 :)

OK, fair enough. Is this documented somewhere or just common knowledge?

Thank you for merging. :)

@avdv avdv deleted the cb/fix-abs-issue-3068 branch December 13, 2024 12:22
@illicitonion
Copy link
Collaborator

Our support policy can be found at https://bazelbuild.github.io/rules_rust/#supported-bazel-versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of abs bazel function removes compatibility from bazel <7
2 participants