feat: add an attr to rust_binary for customization of the binary name #2970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattem
force-pushed
the
rust_binary_name_attr
branch
2 times, most recently
from
bb7da7e to
e527162
Compare
mattem
force-pushed
the
rust_binary_name_attr
branch
from
e527162 to
2607183
Compare
illicitonion
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's often desirable to set the name of the resulting binary to something else other than the target name (
attr.name), perhaps when therust_binarytarget is wrapped in a macro, and not considered the "main" target of that macro.This diff adds a new
binary_nameattribute torust_binary, which when set will be used as the resulting binaries prefix instead of the targets name. The default is to still use the target name.