Updated Bazelmod cross compilation to catch MacOS sys dependency issues #2926
+188
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
|
Update:
However, I am not familiar with BazelCI, but is there a way to add a single MacOS runner that basically runs all Bazelmod tests similar to the crate universe runner for the Workspace examples? Would be great if someone with a solid understanding of the CI would ensure that all Bazelmod examples get build and tested on MacOS. |
krasimirgg
requested changes
Oct 14, 2024
.bazelci/presubmit.yml
Outdated
| platform: ubuntu2004 | ||
| working_directory: examples/bzlmod/proto_with_toolchain | ||
| build_targets: | ||
| - "//..." |
There was a problem hiding this comment.
is this removal intentional?
There was a problem hiding this comment.
Nope, that was an accident. Probably a cut instead of copy.
Good catch. Thanks for point it out.
Resolves: bazelbuild#2926 (comment) Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Resolves: bazelbuild#2926 (comment) Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
Resolves: bazelbuild#2926 (comment) Signed-off-by: Marvin Hansen <marvin.hansen@gmail.com>
|
@krasimirgg I addresses all of your issues with the latest commits. Please review again. |
krasimirgg
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue #2917,
this updated cross compilation example serves as a bridge until the exact cause of the sys crates not building on Mac issue has been found and better regression testing has been added.
Also, I took the freedom to trim and streamline the LLVM setup making it easier to configure while preserving the property that it caches failing sys crate builds. Updated the Readme accordingly.