Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix platform validation for wasm32-wasip1 target #2894

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

c16a
Copy link
Contributor

@c16a c16a commented Sep 23, 2024

This fix validation errors for the new wasm32-wasip1 target. The older wasm32-wasi is already covered. Fixes #2782

Signed-off-by: Chaitanya Munukutla <chaitanya.m61292@gmail.com>
@c16a
Copy link
Contributor Author

c16a commented Sep 23, 2024

@UebelAndre can you please review this?

Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, thanks!

@c16a
Copy link
Contributor Author

c16a commented Sep 24, 2024

@UebelAndre seems like the build failed due to an intermittent network issue. Can you please help re-trigger?

@UebelAndre UebelAndre added this pull request to the merge queue Oct 3, 2024
Merged via the queue into bazelbuild:main with commit ab50fce Oct 3, 2024
4 checks passed
zemnmez-renovate-bot added a commit to zemn-me/monorepo that referenced this pull request Oct 4, 2024
##### [`v0.52.0](https://github.com/bazelbuild/rules_rust/releases/tag/0.52.0)

### 0.52.0

#### Bzlmod

```python
bazel_dep(name = "rules_rust", version = "0.52.0")
```

#### WORKSPACE

```python
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
http_archive(
    name = "rules_rust",
    integrity = "sha256-eTHntUQQe2ICm/L8cuefnXdSOtZQ1ELZPD/M6a1ewes=",
    urls = ["https://github.com/bazelbuild/rules_rust/releases/download/0.52.0/rules_rust-v0.52.0.tar.gz"],
)
```

Additional documentation can be found at: https://bazelbuild.github.io/rules_rust/#setup

#### What's Changed

-   Allowlist more clang flags in bindgen by [@hlopko](https://github.com/hlopko) in bazelbuild/rules_rust#2902
-   Allow `+` in repo names by [@fmeum](https://github.com/fmeum) in bazelbuild/rules_rust#2908
-   Added utility for parsing action Args param files by [@UebelAndre](https://github.com/UebelAndre) in bazelbuild/rules_rust#2897
-   Updated platform triple mapping to support T3 platforms without `std`. by [@UebelAndre](https://github.com/UebelAndre) in bazelbuild/rules_rust#2899
-   Fix `override_targets` keys in docs by [@max-heller](https://github.com/max-heller) in bazelbuild/rules_rust#2905
-   Use absolute path with "-fsanitize-ignorelist" by [@vitalybuka](https://github.com/vitalybuka) in bazelbuild/rules_rust#2911
-   Fix platform validation for wasm32-wasip1 target by [@c16a](https://github.com/c16a) in bazelbuild/rules_rust#2894
-   Update `cargo_build_script` to always render custom runfiles dirs. by [@UebelAndre](https://github.com/UebelAndre) in bazelbuild/rules_rust#2891
-   Check target tags before ignore tags for lint/fmt aspects by [@UebelAndre](https://github.com/UebelAndre) in bazelbuild/rules_rust#2913
-   Get rolling releases CI green by [@illicitonion](https://github.com/illicitonion) in bazelbuild/rules_rust#2916
-   Avoid uses of shell to improve Windows tests by [@UebelAndre](https://github.com/UebelAndre) in bazelbuild/rules_rust#2912
-   Prep release 0.52.0 by [@illicitonion](https://github.com/illicitonion) in bazelbuild/rules_rust#2910

#### New Contributors

-   [@fmeum](https://github.com/fmeum) made their first contribution in bazelbuild/rules_rust#2908
-   [@max-heller](https://github.com/max-heller) made their first contribution in bazelbuild/rules_rust#2905
-   [@vitalybuka](https://github.com/vitalybuka) made their first contribution in bazelbuild/rules_rust#2911
-   [@c16a](https://github.com/c16a) made their first contribution in bazelbuild/rules_rust#2894

**Full Changelog**: bazelbuild/rules_rust@0.51.0...0.52.0
github-merge-queue bot pushed a commit to zemn-me/monorepo that referenced this pull request Oct 4, 2024
##### [`v0.52.0](https://github.com/bazelbuild/rules_rust/releases/tag/0.52.0)

### 0.52.0

#### Bzlmod

```python
bazel_dep(name = "rules_rust", version = "0.52.0")
```

#### WORKSPACE

```python
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
http_archive(
    name = "rules_rust",
    integrity = "sha256-eTHntUQQe2ICm/L8cuefnXdSOtZQ1ELZPD/M6a1ewes=",
    urls = ["https://github.com/bazelbuild/rules_rust/releases/download/0.52.0/rules_rust-v0.52.0.tar.gz"],
)
```

Additional documentation can be found at: https://bazelbuild.github.io/rules_rust/#setup

#### What's Changed

-   Allowlist more clang flags in bindgen by [@hlopko](https://github.com/hlopko) in bazelbuild/rules_rust#2902
-   Allow `+` in repo names by [@fmeum](https://github.com/fmeum) in bazelbuild/rules_rust#2908
-   Added utility for parsing action Args param files by [@UebelAndre](https://github.com/UebelAndre) in bazelbuild/rules_rust#2897
-   Updated platform triple mapping to support T3 platforms without `std`. by [@UebelAndre](https://github.com/UebelAndre) in bazelbuild/rules_rust#2899
-   Fix `override_targets` keys in docs by [@max-heller](https://github.com/max-heller) in bazelbuild/rules_rust#2905
-   Use absolute path with "-fsanitize-ignorelist" by [@vitalybuka](https://github.com/vitalybuka) in bazelbuild/rules_rust#2911
-   Fix platform validation for wasm32-wasip1 target by [@c16a](https://github.com/c16a) in bazelbuild/rules_rust#2894
-   Update `cargo_build_script` to always render custom runfiles dirs. by [@UebelAndre](https://github.com/UebelAndre) in bazelbuild/rules_rust#2891
-   Check target tags before ignore tags for lint/fmt aspects by [@UebelAndre](https://github.com/UebelAndre) in bazelbuild/rules_rust#2913
-   Get rolling releases CI green by [@illicitonion](https://github.com/illicitonion) in bazelbuild/rules_rust#2916
-   Avoid uses of shell to improve Windows tests by [@UebelAndre](https://github.com/UebelAndre) in bazelbuild/rules_rust#2912
-   Prep release 0.52.0 by [@illicitonion](https://github.com/illicitonion) in bazelbuild/rules_rust#2910

#### New Contributors

-   [@fmeum](https://github.com/fmeum) made their first contribution in bazelbuild/rules_rust#2908
-   [@max-heller](https://github.com/max-heller) made their first contribution in bazelbuild/rules_rust#2905
-   [@vitalybuka](https://github.com/vitalybuka) made their first contribution in bazelbuild/rules_rust#2911
-   [@c16a](https://github.com/c16a) made their first contribution in bazelbuild/rules_rust#2894

**Full Changelog**: bazelbuild/rules_rust@0.51.0...0.52.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New wasi targets are invalid
2 participants