Allow crates_vendor to read the CARGO_BAZEL_DEBUG env var
#2862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
approved these changes
Sep 13, 2024
| exec env - BAZEL_REAL="${{BAZEL_REAL}}" BUILD_WORKSPACE_DIRECTORY="${{BUILD_WORKSPACE_DIRECTORY}}" PATH="${{PATH}}" {env} \\ | ||
| "{bin}" {args} "$@" | ||
| exec env - \\ | ||
| ${{_ENVIRON[@]}} \\ |
There was a problem hiding this comment.
I think this array expansion need to be quoted in order to properly handle paths that contain spaces.
There was a problem hiding this comment.
I'd be happy to review a pull-request!
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
Slight tweak to the logic in #2862 (cc: @UebelAndre) My `$PATH` variable has spaces in it and I hit an error like ``` env: Support/JetBrains/Toolbox/scripts:/Users/ryanpbrewster/.bin:/Users/ryanpbrewster/config/bin:/Users/ryanpbrewster/.local/bin:/Applications/Visual: No such file or directory ``` If I manually modify `bazel-bin/rust/crates_vendor.sh` to modify ``` exec env - \ ${_ENVIRON[@]} \ ``` into ``` exec env - \ "${_ENVIRON[@]}" \ ``` it starts working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the environment variable was discarded. Now users can see debug info about how crates are being rendered.