Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Rust 1.81.0 #2841

Merged
merged 7 commits into from
Sep 10, 2024
Merged

Added Rust 1.81.0 #2841

merged 7 commits into from
Sep 10, 2024

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre
Copy link
Collaborator Author

This change is blocked by #2840

@UebelAndre UebelAndre mentioned this pull request Sep 6, 2024
Merged
This was referenced Sep 6, 2024
Merged
Closed
illicitonion
illicitonion approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd ideally like to merge #2851 and hopefully stop disabling the musl job if possible :)

@UebelAndre
Copy link
Collaborator Author

LGTM, but I'd ideally like to merge #2851 and hopefully stop disabling the musl job if possible :)

I'll wait for that to go in and rebase!

@UebelAndre
Copy link
Collaborator Author

UebelAndre commented Sep 10, 2024 •
edited
Loading

@illicitonion looks like the build is still failing 😞

https://buildkite.com/bazel/rules-rust-rustlang/builds/12063#0191dd06-b0aa-47cc-a03e-73dd0ce45748

@UebelAndre UebelAndre added this pull request to the merge queue Sep 10, 2024
@illicitonion
Copy link
Collaborator

@illicitonion looks like the build is still failing 😞

https://buildkite.com/bazel/rules-rust-rustlang/builds/12063#0191dd06-b0aa-47cc-a03e-73dd0ce45748

I started looking - it looks like on macOS we're using 1.81.0 and on linux we're using 1.80.0... Which seems weird...

@UebelAndre UebelAndre removed this pull request from the merge queue due to a manual request Sep 10, 2024
@illicitonion
Explicitly set RUST_VERSION
18d5943 
Previously we were getting the default version for default toolchains,
and the overridden version for overridden toolchains. We always want one
consistent version.
@illicitonion
Copy link
Collaborator

I think the commit I just pushed should fix it :)

@UebelAndre UebelAndre added this pull request to the merge queue Sep 10, 2024
@UebelAndre
Copy link
Collaborator Author

UebelAndre commented Sep 10, 2024 •
edited
Loading

I think the commit I just pushed should fix it :)

Seems like it! Sweet but super weird too!
I lied, I'm finding out now!

@UebelAndre UebelAndre removed this pull request from the merge queue due to a manual request Sep 10, 2024
@illicitonion illicitonion added this pull request to the merge queue Sep 10, 2024
Merged via the queue into bazelbuild:main with commit 1ade187 Sep 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UebelAndre @illicitonion