Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for thumbv7em with hard float #1871

Merged
merged 7 commits into from
Mar 15, 2023

Conversation

Codetector1374
Copy link
Contributor

No description provided.

@hexdae
Copy link

hexdae commented Mar 14, 2023

Thanks for opening this. Having an example of cross-compilation for this target would also be awesome. I could help out with this if needed

Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One question.

rust/platform/triple_mappings.bzl Outdated Show resolved Hide resolved
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@UebelAndre
Copy link
Collaborator

Looks like you need a rebase

@Codetector1374
Copy link
Contributor Author

done

@UebelAndre UebelAndre merged commit 9e9853d into bazelbuild:main Mar 15, 2023
nyurik pushed a commit to nyurik/rules_rust that referenced this pull request Mar 28, 2023
* Fix triple mapping error handling

* Add thumbv7em and eabihf to triple mapping

* Add thumbv7em and eabihf to triple mapping

* Add thumbv7em and eabihf to triple mapping

* Add documentation

* Fix formatting

* refactor cpu_arch_to_constraints interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants