[crate_universe] add an annotation to disable pipelining #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calsign
changed the title
Calsign
changed the title
Calsign
force-pushed
the
crate-universe-annotation-disable-pipelining
branch
from
1768e46 to
a197786
Compare
|
LGTM, thanks! Could you add a test to https://github.com/bazelbuild/rules_rust/blob/main/crate_universe/src/rendering.rs which shows this gets properly passed through the system? Then I'm happy to merge! |
Calsign
force-pushed
the
crate-universe-annotation-disable-pipelining
branch
3 times, most recently
from
33fd72f to
cca5c06
Compare
The recent support for pipelined compilation (bazelbuild#1275) is great. There are some situations, however, where we need to disable pipelining for specific crates, e.g. bazelbuild#1584. This PR adds a crate annotation option to disable pipelining for rust_library targets generated by cargo_bazel.
Calsign
force-pushed
the
crate-universe-annotation-disable-pipelining
branch
2 times, most recently
from
ac43c42 to
dd68273
Compare
|
@illicitonion I have added such a test, I think it should be good to merge now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent support for pipelined compilation (#1275) is great. There are some situations, however, where we need to disable pipelining for specific crates, e.g. #1584. This PR adds a crate annotation option to disable pipelining for rust_library targets generated by cargo_bazel. The alternatives would be patching the crate with the annotations system or disabling pipelining globally.