-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore basic functionality of the C++ process wrapper #1728
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor cleanup
I did not see #1530 (comment). Sorry for the delay, continuing the thread here. I get consistent results running build->clean->build but I tried doing this in two different checkouts of the same commit and ended up with different results. Which makes me think the remapping flag is actually just not working?
Note things around |
Fixes #1530
The process wrapper, among other things, takes care of passing
--remap-path-prefix=$PWD=
with the correct $PWD value for the Rust compilation actions. The process wrapper is a Rust binary itself, and currently there is nothing to take care of passing--remap-path-prefix
when it is being built, which results in nondeterministic process wrapper build. This PR provides a solution for the issue, by building the process wrapper and its dependencies via a minimal C++ process wrapper (which I resurrected from before d9ba374).We could once again remove the C++ process wrapper once
remap-cwd-prefix
is stabilized (rust-lang/rust#89434).