Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix issue with wasi-0.11.0+wasi-snapshot-preview1 #1632

Merged
merged 5 commits into from
Nov 10, 2022
Merged

fix: Fix issue with wasi-0.11.0+wasi-snapshot-preview1 #1632

merged 5 commits into from
Nov 10, 2022

Conversation

semtexzv
Copy link
Contributor

@semtexzv semtexzv commented Nov 5, 2022

Handles paths with plus in package name

@semtexzv semtexzv mentioned this pull request Nov 5, 2022
Closed
UebelAndre
UebelAndre requested changes Nov 5, 2022
View reviewed changes
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you think you could also add a regression test for this?

UebelAndre
UebelAndre approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you!

@UebelAndre UebelAndre mentioned this pull request Nov 9, 2022
Merged
UebelAndre
UebelAndre approved these changes Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@UebelAndre UebelAndre merged commit ab6959d into bazelbuild:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UebelAndre UebelAndre UebelAndre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@semtexzv @UebelAndre