Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wasm_bindgen to 0.2.82 #1513

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

ImJeremyHe
Copy link
Contributor

related to #1509

@google-cla
Copy link

google-cla bot commented Aug 13, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together! Just one question 😄

@@ -29,7 +29,6 @@ crates_vendor(
"--cfg=ossl102h",
"--cfg=ossl110",
"--cfg=ossl110f",
"--cfg=ossl110g",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this dropped?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, It must be a misoperation. I updated this PR. Thank you!

@ImJeremyHe ImJeremyHe force-pushed the jeremyhe/update-wasm-bindgen branch from 7c96fc2 to 948e1c6 Compare August 15, 2022 01:00
@ImJeremyHe ImJeremyHe force-pushed the jeremyhe/update-wasm-bindgen branch from 948e1c6 to 1d83075 Compare August 15, 2022 01:09
Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@UebelAndre UebelAndre merged commit 3a69ce0 into bazelbuild:main Aug 15, 2022
@ImJeremyHe ImJeremyHe deleted the jeremyhe/update-wasm-bindgen branch August 15, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants