Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added TemplateVariableInfo to rust_toolchain. #1416

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Added TemplateVariableInfo to rust_toolchain. #1416

merged 1 commit into from
Jun 27, 2022

Conversation

UebelAndre
Copy link
Collaborator

@UebelAndre UebelAndre commented Jun 17, 2022 •
edited
Loading

This change allows rust_toolchain to directly provide expandable make variables instead of relying on current_rust_toolchain.

closes #1412

@UebelAndre UebelAndre mentioned this pull request Jun 17, 2022
Closed
@UebelAndre UebelAndre marked this pull request as ready for review June 25, 2022 14:27
@UebelAndre UebelAndre requested a review from illicitonion June 25, 2022 14:27
illicitonion
illicitonion approved these changes Jun 27, 2022
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@UebelAndre UebelAndre enabled auto-merge (squash) June 27, 2022 13:29
@UebelAndre UebelAndre merged commit 52fc701 into bazelbuild:main Jun 27, 2022
@UebelAndre UebelAndre deleted the make_variables branch June 27, 2022 13:35
@UebelAndre UebelAndre mentioned this pull request Jul 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UebelAndre @illicitonion