-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra_rustc_flag and extra_exec_rustc_flag #1413
Conversation
bf22eac
to
c2420a4
Compare
How are we going to deal with the Min Bazel version failing CIs again? |
PR for it. #1414 |
Perfect! I believe we'll need to land that first, otherwise we won't be able to push this with ongoing failing buildbots. |
2216848
to
28f5f01
Compare
@krasimirgg ping; what should I do next?? |
@@ -102,9 +104,15 @@ capture_clippy_output = _capture_clippy_output | |||
error_format = _error_format | |||
# See @rules_rust//rust/private:rustc.bzl for a complete description. | |||
|
|||
extra_rustc_flag = _extra_rustc_flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can yo make sure the new flags are added to docs? You should only need to update https://github.com/bazelbuild/rules_rust/blob/0.6.0/docs/symbols.bzl and https://github.com/bazelbuild/rules_rust/blob/0.6.0/docs/BUILD.bazel#L46-L60. Then CI will tell you to run ./docs/update_docs.sh
from the root of the repo.
6252b21
to
37a39e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest version looks good.
Retake of #1407.
Each new flags are singular, and appended after the flags passed to plural ones.
Use case: