Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated rules_rust version to 0.6.0. #1397

Merged
merged 2 commits into from
Jun 14, 2022
Merged

Conversation

UebelAndre
Copy link
Collaborator

No description provided.

@UebelAndre
Copy link
Collaborator Author

@scentini
Copy link
Collaborator

Could we please also wait for a solution for #1374, which should come today/early next week?

@kalcutter
Copy link
Contributor

Please also include #1371 if its possible to get that merged in a reasonable amount of time.

@kalcutter
Copy link
Contributor

#1371 has been merged 🎉

@UebelAndre
Copy link
Collaborator Author

Could we please also wait for a solution for #1374, which should come today/early next week?

@scentini hey, any updates here? I'd love to be able to get a release out and think it'd be worth while to do a patch release whenever this is fixed.

@scentini
Copy link
Collaborator

If a patch release is on the table let's not block 0.6.0. I tried multiple approaches yesterday, but there are some issues with macos behavior (and I haven't gotten yet to checking Windows), and while I'm actively investigating, I don't have a timeline for the fix just yet.

@UebelAndre UebelAndre enabled auto-merge (squash) June 14, 2022 14:52
@UebelAndre
Copy link
Collaborator Author

If a patch release is on the table let's not block 0.6.0. I tried multiple approaches yesterday, but there are some issues with macos behavior (and I haven't gotten yet to checking Windows), and while I'm actively investigating, I don't have a timeline for the fix just yet.

I'd like releases to be an easy and light weight thing to do. So I would consider a patch release (or even a new release) something always on the table. Anyone can open a PR updating the version and the automated deploy action takes care of the rest.

@UebelAndre UebelAndre requested a review from scentini June 14, 2022 15:17
@UebelAndre UebelAndre merged commit 91466fc into bazelbuild:main Jun 14, 2022
@UebelAndre UebelAndre deleted the releases branch June 14, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants