Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ran clang-format on all C++ sources #1396

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

UebelAndre
Copy link
Collaborator

Minor cleanup. The following config was used:

---
BasedOnStyle: Google
...

@UebelAndre UebelAndre changed the title Ran clang format on all C++ sources Ran clang-format on all C++ sources Jun 9, 2022
@UebelAndre UebelAndre force-pushed the clang-format branch 2 times, most recently from 953606c to 094c98e Compare June 9, 2022 14:17
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is worthwhile... If we're going to apply formatting, I think I'd want to have CI enforce that we stay formatted, but given we only really have C/C++ in tests and examples, I'm not sure it's worth gating CI on test formatting... Is there a strong motivation here?

@UebelAndre
Copy link
Collaborator Author

I'm not sure this is worthwhile... If we're going to apply formatting, I think I'd want to have CI enforce that we stay formatted, but given we only really have C/C++ in tests and examples, I'm not sure it's worth gating CI on test formatting... Is there a strong motivation here?

I was testing some other rules I wrote to run clang-format and thought I'd just push the changes to have cleaner code. This PR can be rejected since it doesn't add enforcement but figured the cleanup wouldn't hurt.

@UebelAndre UebelAndre merged commit 8fca438 into bazelbuild:main Jun 9, 2022
@UebelAndre UebelAndre deleted the clang-format branch June 9, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants