Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Clippy bug with --@rules_rust//:clippy_flags. #1392

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

UebelAndre
Copy link
Collaborator

This change fixes the following error when using the --@rules_rust//:clippy_flags config setting

ERROR: /Users/user/Code/rules_rust/test/clippy/BUILD.bazel:19:10: in //rust/private:clippy.bzl%rust_clippy_aspect aspect on rust_test rule //test/clippy:ok_test:
Traceback (most recent call last):
	File "/Users/user/Code/rules_rust/rust/private/clippy.bzl", line 147, column 29, in _clippy_aspect_impl
		args.rustc_flags.extend(clippy_flags)
Error: 'Args' value has no field or method 'extend'
WARNING: errors encountered while analyzing target '//test/unit/clippy:library_clippy_aspect_with_extra_flags_test': it will not be built

Regression testing was also added to catch future breakages.

@UebelAndre UebelAndre requested a review from scentini June 7, 2022 21:31
Copy link
Collaborator

@scentini scentini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@UebelAndre UebelAndre merged commit 81590f4 into bazelbuild:main Jun 8, 2022
@UebelAndre UebelAndre deleted the clippy branch June 8, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants