Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add armv7-linux-androideabi tier 2 triple #1362

Merged
merged 2 commits into from
May 27, 2022
Merged

Add armv7-linux-androideabi tier 2 triple #1362

merged 2 commits into from
May 27, 2022

Conversation

keith
Copy link
Member

@keith keith commented May 26, 2022 •
edited
Loading

@keith keith mentioned this pull request May 26, 2022
Merged
UebelAndre
UebelAndre approved these changes May 26, 2022
View reviewed changes
Copy link
Collaborator

@UebelAndre UebelAndre left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The secret to passing CI is to do the following:

  • run ./docs/update_docs.sh
  • run cd examples/crate_universe && REPIN=1 bazel test //... (note tests do not need to pass)

If you commit and push the results from that I think CI will be happy.

@keith keith force-pushed the ks/add-armv7-linux-androideabi-tier-2-triple branch from 0421405 to 4d91954 Compare May 27, 2022 16:03
@UebelAndre UebelAndre merged commit 1b451c3 into bazelbuild:main May 27, 2022
@keith keith deleted the ks/add-armv7-linux-androideabi-tier-2-triple branch May 27, 2022 17:13
@keith
Copy link
Member Author

keith commented May 27, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UebelAndre UebelAndre UebelAndre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keith @UebelAndre