Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace slashes with underscores in default crate names. #1336

Merged
merged 1 commit into from
May 13, 2022

Conversation

cfredric
Copy link
Contributor

This is another attempt at #1334, which sought to make "/" characters legal in Rust target names.

This PR differs from #1334 in how it handles build artifacts that are based on crate_info.output. There are a few places that currently assume that calling ctx.actions.declare_file(...) will always declare a file in the same directory as crate_info.output, i.e. as ctx.actions.declare_file(ctx.label.name + ...). In a world where label names may include slashes (which is the case today!), this is not a safe assumption, since a slash in the target name causes bazel to create a subdirectory for the output.

Specifically, this PR fixes incorrect locations for the following items (when the target name includes a slash):

  • PDB files
  • dSYM files
  • .lib files

This leaves a few things that look like they make the same assumption, but I'm not sure how they're used or if they should be updated:

  • "_ambiguous_libs/" + crate_info.output.basename + "/" + symlink_name for ambiguous libraries
  • The linkstamp output path ("_objs/" + crate_info.output.basename + "/" + ...)

@scentini scentini self-requested a review May 13, 2022 20:25
Copy link
Collaborator

@scentini scentini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@scentini scentini merged commit a066bfe into bazelbuild:main May 13, 2022
@cfredric cfredric deleted the slash_names_redux branch May 13, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants