Don't leak additive build file content across crates #1278
Conversation
| content = "\n".join([ | ||
| data.pop("additive_build_file_content", None) or "", | ||
| repository_ctx.read(Label(f)) if f else "", | ||
| ]).strip() |
There was a problem hiding this comment.
Since this content is generally rendered at the bottom of a file, could we avoid the strip so we don't strip the final newline?
There was a problem hiding this comment.
Hmm, good point. The strip is there to prevent the content from being just \n, as well as keeping the source a bit cleaner. Would it make sense to explicitly add a newline in addition to stripping? Since there is no guarantee of a newline from repository_ctx.read anyway.
There was a problem hiding this comment.
I lean toward the more hands off approach where we just render what users told us. That way folks who care about newlines have the power to fix it
There was a problem hiding this comment.
I agree, that makes sense. Would you mind taking another look?
Fixes #1277