-
Notifications
You must be signed in to change notification settings - Fork 443
Comparing changes
Open a pull request
base repository: bazelbuild/rules_rust
base: 0.3.1
head repository: bazelbuild/rules_rust
compare: 0.4.0
- 20 commits
- 120 files changed
- 10 contributors
Commits on Apr 26, 2022
-
Make get_host_triple public to get a triple from Bazel's repository_c…
…tx (#1289) I found half-baked duplicate implementations of this logic in cargo-raze, in cxx, and in rules_rust's test suite of the load_arbitrary_tool function. It seems such logic is necessary for correctly using load_arbitrary_tool from the implementation of a repository_rule.
Configuration menu - View commit details
-
Copy full SHA for 58627f5 - Browse repository at this point
Copy the full SHA 58627f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97de47d - Browse repository at this point
Copy the full SHA 97de47dView commit details
Commits on Apr 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a6f332f - Browse repository at this point
Copy the full SHA a6f332fView commit details -
rustc: fix a conditional (#1300)
`("bar" or "baz")` always evaluates to "bar", so this conditional ignores `"dylib"`. This seems unintended.
Configuration menu - View commit details
-
Copy full SHA for c63ad97 - Browse repository at this point
Copy the full SHA c63ad97View commit details -
Updated crate_universe docs (#1301)
* Updated crate_universe docs * Regenerate documentation * Update crate_universe/private/crates_vendor.bzl Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com> * Update crate_universe/private/crates_repository.bzl Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com> * Regenerate documentation Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e07881f - Browse repository at this point
Copy the full SHA e07881fView commit details
Commits on Apr 28, 2022
-
fix for using a nightly channel after 841fc6f (#1302)
The commit 841fc6f for #1284 broke the ability to use rust_register_toolchains with a nightly channel, see 841fc6f#commitcomment-72310891. I tracked the issue down to this line which was updated there. While using a dated nightly, these variables look like: * tool_path: `rust-nightly-x86_64-unknown-linux-gnu` * tool_suburl: `2022-04-06/rust-nightly-x86_64-unknown-linux-gnu` Using tool_suburl causes the extract to fail like in the comment above: `Prefix "2022-04-06/rust-nightly-x86_64-unknown-linux-gnu/rustc" was given, but not found in the archive. Here are possible prefixes for this archive: "rust-nightly-x86_64-unknown-linux-gnu".` Switching back to the old behaviour fixes the glitch. I'm not sure if this breaks novel use cases introduced by 841fc6f; @wt, could you please take a look. On a sidenote, this is an instance where having some some build bot CI that uses nightly would have noticed this.
Configuration menu - View commit details
-
Copy full SHA for 0175a1b - Browse repository at this point
Copy the full SHA 0175a1bView commit details -
Don't emit
CrateInfo
fromrust_static_library
and `rust_shared_li……brary` (#1298) These rules emit a `staticlib` and `cdylib` which are not meant for consumption by other rust targets. However, one should still be able to write a `rust_test` for `rust_shared_library` and `rust_static_library` targets, which needs a `CrateInfo`. For this purpose we provide a `CrateInfo` wrapped in a `TestCrateInfo` provider, that `rust_test` understands.
Configuration menu - View commit details
-
Copy full SHA for 5abeb93 - Browse repository at this point
Copy the full SHA 5abeb93View commit details -
Don't propagate non-shared transitive linker inputs from `rust_static…
…|shared_library` (#1299) A Rust `staticlib` or `cdylib` doesn't need to propagate linker inputs of its dependencies, except for shared libraries. - The tests are currently disabled on osx because the CI [Toolchain does not support dynamic linking]( https://buildkite.com/bazel/rules-rust-rustlang/builds/6126#a83dbb56-50b0-4a95-bb39-09e3a78ed0d0). - I also had to link to `Bcrypt.lib` => rust-lang/rust#91974
Configuration menu - View commit details
-
Copy full SHA for d86e06a - Browse repository at this point
Copy the full SHA d86e06aView commit details
Commits on Apr 29, 2022
-
Remove doc about STATIC_RUST_URL env var. (#1306)
This var was removed in a previous commit in order to unify the handling of the fetching of all assets.
Wren Turkal authoredApr 29, 2022 Configuration menu - View commit details
-
Copy full SHA for 1cab691 - Browse repository at this point
Copy the full SHA 1cab691View commit details -
Use tinyjson from crates.io instead of github.com. (#1309)
We should be pulling in deps from crates.io as much as possible since the downloads will usually be smaller, and we can avoid a proliferation of remote locations for resources. Fixes #1273
Wren Turkal authoredApr 29, 2022 Configuration menu - View commit details
-
Copy full SHA for b04fe3b - Browse repository at this point
Copy the full SHA b04fe3bView commit details
Commits on May 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for bddc4bd - Browse repository at this point
Copy the full SHA bddc4bdView commit details -
crate_universe: Improved documentation (#1305)
* crate_universe: updated documentation * crate_universe: added dependencies API to docs * Regenerate documentation * Update crate_universe/docs.bzl Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com> * Regenerate documentation Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 42f78f2 - Browse repository at this point
Copy the full SHA 42f78f2View commit details
Commits on May 4, 2022
-
Add bazel-* directories in cargo_manifest_dir/external_crate to gitig…
…nore (#1279) Previously running `bazel build ...` in examples/cargo_manfest_dir/external_crate would leave the following untracked files: Untracked files: (use "git add <file>..." to include in what will be committed) examples/cargo_manifest_dir/external_crate/bazel-bin examples/cargo_manifest_dir/external_crate/bazel-external_crate examples/cargo_manifest_dir/external_crate/bazel-out examples/cargo_manifest_dir/external_crate/bazel-testlogs I noticed that of the 5 workspaces found by `find . -name WORKSPACE.bazel` three of them were ignoring "bazel-*" via the top-level .gitignore while one had its own .gitignore containing only "bazel-*". I consolidated that one into the top-level .gitignore and added the 5th.
Configuration menu - View commit details
-
Copy full SHA for 61eee54 - Browse repository at this point
Copy the full SHA 61eee54View commit details -
Add support for aarch64-apple-ios-sim (#1304)
This adds / improves support for for the arm64 iOS simulator that's used on M1 macs. Previously there was ambiguity in the constraints used for this platform because bazel does not pick the best match, so this adds the device constraint in this case to disambiguate. Ideally we could rely on not having the `sim` suffix to be enough to add the device constraint, but older triples like `x86_64-apple-ios` break this pattern. I broke this logic out into a new function since it relies on more info from the triple than just the ABI now. bazelbuild/bazel#11454 Co-authored-by: UebelAndre <github@uebelandre.com>
Configuration menu - View commit details
-
Copy full SHA for 73d0164 - Browse repository at this point
Copy the full SHA 73d0164View commit details
Commits on May 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1590670 - Browse repository at this point
Copy the full SHA 1590670View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb4d554 - Browse repository at this point
Copy the full SHA fb4d554View commit details -
Updated wasm_bindgen dependencies API (#1313)
* Updated wasm_bindgen dependencies API * Regenerate documentation
Configuration menu - View commit details
-
Copy full SHA for d7c532c - Browse repository at this point
Copy the full SHA d7c532cView commit details
Commits on May 9, 2022
-
Error calling
all_crate_deps
withoutCargo.toml
(#1327)Previously, we would silently return `[]`. This is incorrect; a user should not be attempting to get deps which weren't declared, and silently doing so can lead to some frustrating debugging. Fixes #1322.
Configuration menu - View commit details
-
Copy full SHA for fccaae3 - Browse repository at this point
Copy the full SHA fccaae3View commit details -
Support . workspace member (#1326)
* Support . workspace member Previously, if a workspace included `.` as a member, we could consistently error and nothing could be done about it. * Label serializes :foo as //:foo * Ignore crate_universe/private/bootstrap This is used as a staging ground for local repositories when iterating locally. * Re-vendor 3rdparty crates This adds normpath, and otherwise is just updates.
Configuration menu - View commit details
-
Copy full SHA for d3d9aba - Browse repository at this point
Copy the full SHA d3d9abaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 21eed19 - Browse repository at this point
Copy the full SHA 21eed19View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 0.3.1...0.4.0