Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bazelbuild/rules_rust
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.3.1
Choose a base ref
...
head repository: bazelbuild/rules_rust
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.4.0
Choose a head ref
  • 20 commits
  • 120 files changed
  • 10 contributors

Commits on Apr 26, 2022

  1. Make get_host_triple public to get a triple from Bazel's repository_c…

    …tx (#1289)
    
    I found half-baked duplicate implementations of this logic in
    cargo-raze, in cxx, and in rules_rust's test suite of the
    load_arbitrary_tool function. It seems such logic is necessary for
    correctly using load_arbitrary_tool from the implementation of a
    repository_rule.
    dtolnay authored Apr 26, 2022
    Copy the full SHA
    58627f5 View commit details
  2. Copy the full SHA
    97de47d View commit details

Commits on Apr 27, 2022

  1. Copy the full SHA
    a6f332f View commit details
  2. rustc: fix a conditional (#1300)

    `("bar" or "baz")` always evaluates to "bar", so this conditional ignores `"dylib"`. This seems unintended.
    gburgessiv authored Apr 27, 2022
    Copy the full SHA
    c63ad97 View commit details
  3. Updated crate_universe docs (#1301)

    * Updated crate_universe docs
    
    * Regenerate documentation
    
    * Update crate_universe/private/crates_vendor.bzl
    
    Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
    
    * Update crate_universe/private/crates_repository.bzl
    
    Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
    
    * Regenerate documentation
    
    Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
    UebelAndre and illicitonion authored Apr 27, 2022
    Copy the full SHA
    e07881f View commit details

Commits on Apr 28, 2022

  1. fix for using a nightly channel after 841fc6f (#1302)

    The commit 841fc6f for #1284 broke the ability to use rust_register_toolchains with a nightly channel, see 841fc6f#commitcomment-72310891.
    I tracked the issue down to this line which was updated there. While using a dated nightly, these variables look like:
    * tool_path:  `rust-nightly-x86_64-unknown-linux-gnu`
    * tool_suburl:  `2022-04-06/rust-nightly-x86_64-unknown-linux-gnu`
    
    Using tool_suburl causes the extract to fail like in the comment above:
    `Prefix "2022-04-06/rust-nightly-x86_64-unknown-linux-gnu/rustc" was given, but not found in the archive. Here are possible prefixes for this archive: "rust-nightly-x86_64-unknown-linux-gnu".`
    
    Switching back to the old behaviour fixes the glitch. I'm not sure if this breaks novel use cases introduced by 841fc6f; @wt, could you please take a look.
    
    On a sidenote, this is an instance where having some some build bot CI that uses nightly would have noticed this.
    krasimirgg authored Apr 28, 2022
    Copy the full SHA
    0175a1b View commit details
  2. Don't emit CrateInfo from rust_static_library and `rust_shared_li…

    …brary` (#1298)
    
    These rules emit a `staticlib` and `cdylib` which are not meant for consumption by other rust targets.
    
    However, one should still be able to write a `rust_test` for `rust_shared_library` and `rust_static_library` targets, which needs a `CrateInfo`. For this purpose we provide a `CrateInfo` wrapped in a `TestCrateInfo` provider, that `rust_test` understands.
    scentini authored Apr 28, 2022
    Copy the full SHA
    5abeb93 View commit details
  3. Don't propagate non-shared transitive linker inputs from `rust_static…

    …|shared_library` (#1299)
    
    A Rust `staticlib` or `cdylib` doesn't need to propagate linker inputs of its dependencies, except for shared libraries.
    
    - The tests are currently disabled on osx because the CI [Toolchain does not support dynamic linking]( https://buildkite.com/bazel/rules-rust-rustlang/builds/6126#a83dbb56-50b0-4a95-bb39-09e3a78ed0d0).
    - I also had to link to `Bcrypt.lib` => rust-lang/rust#91974
    scentini authored Apr 28, 2022
    Copy the full SHA
    d86e06a View commit details

Commits on Apr 29, 2022

  1. Remove doc about STATIC_RUST_URL env var. (#1306)

    This var was removed in a previous commit in order to unify the
    handling of the fetching of all assets.
    Wren Turkal authored Apr 29, 2022
    Copy the full SHA
    1cab691 View commit details
  2. Use tinyjson from crates.io instead of github.com. (#1309)

    We should be pulling in deps from crates.io as much as possible
    since the downloads will usually be smaller, and we can avoid
    a proliferation of remote locations for resources.
    
    Fixes #1273
    Wren Turkal authored Apr 29, 2022
    Copy the full SHA
    b04fe3b View commit details

Commits on May 3, 2022

  1. Copy the full SHA
    bddc4bd View commit details
  2. crate_universe: Improved documentation (#1305)

    * crate_universe: updated documentation
    
    * crate_universe: added dependencies API to docs
    
    * Regenerate documentation
    
    * Update crate_universe/docs.bzl
    
    Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
    
    * Regenerate documentation
    
    Co-authored-by: Daniel Wagner-Hall <dawagner@gmail.com>
    UebelAndre and illicitonion authored May 3, 2022
    Copy the full SHA
    42f78f2 View commit details

Commits on May 4, 2022

  1. Add bazel-* directories in cargo_manifest_dir/external_crate to gitig…

    …nore (#1279)
    
    Previously running `bazel build ...` in examples/cargo_manfest_dir/external_crate
    would leave the following untracked files:
    
        Untracked files:
          (use "git add <file>..." to include in what will be committed)
                examples/cargo_manifest_dir/external_crate/bazel-bin
                examples/cargo_manifest_dir/external_crate/bazel-external_crate
                examples/cargo_manifest_dir/external_crate/bazel-out
                examples/cargo_manifest_dir/external_crate/bazel-testlogs
    
    I noticed that of the 5 workspaces found by `find . -name WORKSPACE.bazel`
    three of them were ignoring "bazel-*" via the top-level .gitignore while
    one had its own .gitignore containing only "bazel-*". I consolidated
    that one into the top-level .gitignore and added the 5th.
    dtolnay authored May 4, 2022
    Copy the full SHA
    61eee54 View commit details
  2. Add support for aarch64-apple-ios-sim (#1304)

    This adds / improves support for for the arm64 iOS simulator that's used
    on M1 macs. Previously there was ambiguity in the constraints used for
    this platform because bazel does not pick the best match, so this adds
    the device constraint in this case to disambiguate. Ideally we could
    rely on not having the `sim` suffix to be enough to add the device
    constraint, but older triples like `x86_64-apple-ios` break this
    pattern. I broke this logic out into a new function since it relies on
    more info from the triple than just the ABI now.
    
    bazelbuild/bazel#11454
    
    Co-authored-by: UebelAndre <github@uebelandre.com>
    keith and UebelAndre authored May 4, 2022
    Copy the full SHA
    73d0164 View commit details

Commits on May 6, 2022

  1. Copy the full SHA
    1590670 View commit details
  2. Copy the full SHA
    fb4d554 View commit details
  3. Updated wasm_bindgen dependencies API (#1313)

    * Updated wasm_bindgen dependencies API
    
    * Regenerate documentation
    UebelAndre authored May 6, 2022
    Copy the full SHA
    d7c532c View commit details

Commits on May 9, 2022

  1. Error calling all_crate_deps without Cargo.toml (#1327)

    Previously, we would silently return `[]`. This is incorrect; a user
    should not be attempting to get deps which weren't declared, and
    silently doing so can lead to some frustrating debugging.
    
    Fixes #1322.
    illicitonion authored May 9, 2022
    Copy the full SHA
    fccaae3 View commit details
  2. Support . workspace member (#1326)

    * Support . workspace member
    
    Previously, if a workspace included `.` as a member, we could
    consistently error and nothing could be done about it.
    
    * Label serializes :foo as //:foo
    
    * Ignore crate_universe/private/bootstrap
    
    This is used as a staging ground for local repositories when iterating
    locally.
    
    * Re-vendor 3rdparty crates
    
    This adds normpath, and otherwise is just updates.
    illicitonion authored May 9, 2022
    Copy the full SHA
    d3d9aba View commit details
  3. Copy the full SHA
    21eed19 View commit details
Loading