Switch from using .par files to pure python for piptool and whltool #81
+131,952
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duggelz
force-pushed
the
dgreiman/parectomy
branch
from
a5a8c75 to
ee2e83a
Compare
duggelz
changed the title
|
@mattmoor for your consideration |
|
I suggest using GitHub's "Show changes from commit range..." feature, and skip the ginormous third_party commits. |
added 6 commits
April 16, 2018 14:12
Commands run:
pip install --target=third_party setuptools
rm third_party/easy_install.py{,c}
Commands run: pip install --target=third_party pip
Commands run: pip install --target=third_party wheel
duggelz
force-pushed
the
dgreiman/parectomy
branch
from
f48fa00 to
5601689
Compare
|
I'd love to see this get in, debugging issues with the PAR files is not fun!! |
Closed
|
Can we just use Poetry is doing that and it avoids vendoring almost 400 files (and making the git repo history larger) - https://github.com/soniaai/rules_poetry/blob/master/rules_poetry/defs.bzl#L3-L61 |
|
Closing as release 0.1.0 included a packaging rules implementation that no longer relied on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #67
This vendors several third_party packages, which increases the repository size by 12MB and 116000 lines. Deleting the .par files will get about 6MB of that back.
The .par files will be removed in a separate change.
This change was tested against the rules_k8s repository, and various manual testing.
Alternatives to this change are: