Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(examples): upgrade to v9 and enable ivy #1227

Merged
merged 1 commit into from
Oct 2, 2019
Merged

feat(examples): upgrade to v9 and enable ivy #1227

merged 1 commit into from
Oct 2, 2019

Conversation

gregmagolan
Copy link
Collaborator

@gregmagolan gregmagolan commented Oct 2, 2019 •
edited
Loading

No description provided.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@gregmagolan gregmagolan mentioned this pull request Oct 2, 2019
Closed
12 tasks
@gregmagolan
Copy link
Collaborator Author

@googlebot I consent

1 similar comment
@Toxicable
Copy link

@googlebot I consent

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Oct 2, 2019
@gregmagolan gregmagolan marked this pull request as ready for review October 2, 2019 03:59
alexeagle
alexeagle approved these changes Oct 2, 2019
View reviewed changes
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woohoo! merge away 🌮

@gregmagolan gregmagolan merged commit 1c7426f into bazel-contrib:master Oct 2, 2019
@gregmagolan
Copy link
Collaborator Author

Thanks @Toxicable for getting this in.

Toxicable pushed a commit to Toxicable/rules_nodejs that referenced this pull request Oct 12, 2019
@gregmagolan
feat(examples): upgrade to v9 and enable ivy (bazel-contrib#1227)
af89993
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@soldair soldair Awaiting requested review from soldair

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gregmagolan @googlebot @Toxicable @alexeagle