feat(examples): upgrade to v9 and enable ivy #1185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toxicable
requested review from
alexeagle,
gregmagolan and
soldair
as code owners
alan-agius4
reviewed
Sep 24, 2019
Toxicable
commented
Sep 24, 2019
| // - JIT compilation is discouraged for production use-cases! Consider AOT mode instead. | ||
| // - Did you bootstrap using '@angular/platform-browser-dynamic' or '@angular/platform-server'? | ||
| // - Alternatively provide the compiler with 'import "@angular/compiler";' before bootstrapping. | ||
| // StoreModule.forRoot({todoReducer}) |
There was a problem hiding this comment.
Looks like there's an issue with ngrx
There was a problem hiding this comment.
yeah sync with @gregmagolan - he had this almost working
|
Replaced by #1227 1227 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information