Pass runfiles paths more robustly #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comius
commented
Nov 4, 2022
|
Please split the target refactorings from the bzlmod changes -- it'll be easier to keep track of what moves where. |
comius
force-pushed
the
bzlmod
branch
2 times, most recently
from
9a9cf78
to
be2e94b
Compare
comius
changed the title
This passes runfiles path returned from rootpath function, which is correct in setups with and without using bzlmod.
The Dep.fromLabel works well in combination with kt_rules_test. The same mangling and demangling is used to find runfiles. This is a slight simplification, whcih as well prepared the repo for bzlmod. In addition workaround for autovalue is replaced with a filegroup trick, which works with newer rules_jvm_external repository (where visibility of .jar targets is limited).
I've split them into 2 commits. And will follow up with bzlmod changes. |
restingbull
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass jvm-abi-gen and kotlin-compiler with system property
This passes runfiles path returned from rootpath function, which is correct in setups with and without using bzlmod.
Use Dep.fromLabel in tests to find dependencies
The
Dep.fromLabelworks well in combination withkt_rules_test. The samemangling and demangling is used to find runfiles.
This is a slight simplification, which as well prepares the repo for
bzlmod.
In addition workaround for autovalue is replaced with a filegroup trick,
which works with newer rules_jvm_external repository (where visibility
of .jar targets is limited).