Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change readme file formatting #243

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Change readme file formatting #243

merged 1 commit into from
Jan 15, 2020

Conversation

arturdryomov
Copy link
Contributor

No description provided.

Copy link
Collaborator

@cgruber cgruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@cgruber cgruber added component: documentation P3 status: in review Solution being reviewed type: cleanup Refactorings, idiomatic transforms, tech debt payoff labels Dec 16, 2019
@arturdryomov
Copy link
Contributor Author

@cgruber, just curious — what are required merging conditions? I’m in no hurry to merge this of course, just interested in the process.

@cgruber
Copy link
Collaborator

cgruber commented Jan 15, 2020

... I have to remember to merge it when I say LGTM? :(

Sorry, I'll merge now. Folks on the project can merge their own changes, but in this case, I'll have to merge it .

@cgruber cgruber merged commit 6065c78 into bazelbuild:master Jan 15, 2020
cgruber added a commit to cgruber/rules_kotlin that referenced this pull request Feb 10, 2020
* upstream/master:
  typo and add missing paren.
  Add release legacy-1.3.0
  Reference proper "current release" as legacy 1.3.0
  Update README to account for legacy-1.3.0 release.
  Fix bad date in changelog
  Release the Kotlin rules in a simplified workspace relying on precompiled jars. (bazelbuild#271)
  Update CODEOWNERS (remove str, thomaswk) (bazelbuild#272)
  Factor out external workspace versions and SHA256s into variables conveniently placed at the top. (bazelbuild#259)
  Add a link to the generated documentation (bazelbuild#237)
  Stop using native java rules (bazelbuild#258)
  Add InteliiJ aspect info (bazelbuild#242)
  Change readme file formatting (bazelbuild#243)
  Update CHANGELOG.md
  Update readme to release candidate 4
  Tweak the inference of the test class's package a bit, to support src/test/kotlin/ and kotlin/, since while it's common for kotlin files to live in a /java/ root, it's not UNcommon for them to live in a *kotlin/ root. (bazelbuild#257)
  Passthrough tags to the container android_library (bazelbuild#255)
  Fix current "latest" to actually be the latest.
  Update CHANGELOG.md
  Update to release legacy-1.3.0-rc3
  Support more recent java versions in the kotlin toolchain. (bazelbuild#236)
cgruber added a commit to cgruber/rules_kotlin that referenced this pull request Feb 10, 2020
* origin/master:
  Stop using native java rules (bazelbuild#258)
  Add InteliiJ aspect info (bazelbuild#242)
  Change readme file formatting (bazelbuild#243)
  Update CHANGELOG.md
  Update readme to release candidate 4
  Tweak the inference of the test class's package a bit, to support src/test/kotlin/ and kotlin/, since while it's common for kotlin files to live in a /java/ root, it's not UNcommon for them to live in a *kotlin/ root. (bazelbuild#257)
  Passthrough tags to the container android_library (bazelbuild#255)
  Fix current "latest" to actually be the latest.
jongerrish added a commit to jongerrish/rules_kotlin that referenced this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: documentation P3 status: in review Solution being reviewed type: cleanup Refactorings, idiomatic transforms, tech debt payoff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants