Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

[rules_docker] upstream change ReadImage #671

Conversation

moriarty
Copy link

@moriarty moriarty commented Oct 12, 2021

@k8s-ci-robot k8s-ci-robot requested review from chizhg and fejta October 12, 2021 21:45
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: moriarty
To complete the pull request process, please assign michelle192837 after the PR has been reviewed.
You can assign the PR to them by writing /assign @michelle192837 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @moriarty. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@moriarty
Copy link
Author

closing this #669 fixes it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upstream Change: github.com/bazelbuild/rules_docker/container/go/pkg/compat
2 participants