Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Fix the documentation bug on stamping #544

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

ymotongpoo
Copy link
Contributor

I run the bazel with --workspace_status_command to stamp the values such as GCP project id, GCR repository name, GKE cluster name and so on, and I passed the path to the shellscript as written on README.

However it got error saying "command not found"

$ bazel run //:gke_deploy --verbose_failures
INFO: Analyzed target //:gke_deploy (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
ERROR: Process exited with status 127
/bin/sh: variables.sh: command not found
Target //:gke_deploy failed to build
INFO: Elapsed time: 0.381s, Critical Path: 0.06s
INFO: 0 processes.
FAILED: Build did NOT complete successfully
FAILED: Build did NOT complete successfully

$ cat .bazerlrc
run --workspace_status_command=./variables.sh

I found the exact discussion around this on bazelbuild/bazel#5002. The issue says that --workspace_status_command doesn't accept shellscript was bug at first, and then in the middle of discussion, it was closed. In the thread, some workarounds were proposed but they were not reflected to this repo's README. At least, the description as-is doesn't work, so I'm requesting the fix.

P.S. to the referred bug (bazelbuild/bazel#5002):
I understand the path expression is not platform independent, but stamping itself isn't neither and when we add the lines in .bazelrc we can put platform dependent sections so I don't think not accepting Linux relative path

* Currently `--workspace_status_command` doesn't accept shellscript
  directly
* Change the doc to describe the workaround
@k8s-ci-robot
Copy link

Hi @ymotongpoo. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alex1545
Copy link
Contributor

alex1545 commented Apr 9, 2020

/ok-to-test

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alex1545, ymotongpoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alex1545 alex1545 merged commit 3bb9ba8 into bazelbuild:master Apr 9, 2020
@ymotongpoo ymotongpoo deleted the docs/workspace_status branch April 16, 2020 03:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants