Upgrade Bazel to 4.2.0 #2976
Merged
Upgrade Bazel to 4.2.0 #2976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Were we failing before this change? |
|
No, but perhaps that points to a missing test of some sort? I'm just basing this on the bug fix that was supposedly needed. |
|
To be clear, I'm not blocking at all here. I think the CL is good to go. LGTM + Approval, just wanted to ask if this was coming from an issue filed by the bazel-ci team |
|
Nope! The origin is that I was doing this as part of a larger change updating dependencies in advance of the release, but test failures made me want to reduce the size of that commit to ensure I wasn't getting new behavior with a new bazel version. Thanks for the LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the minimum version of Bazel to 4.2.0, which is required by the removal of
go_tool_libraryin #2922.