Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macOS -install_name linker flag #2699

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

keith
Copy link
Member

@keith keith commented Nov 4, 2020

What does this PR do? Why is it needed?

The macOS toolchain is gaining support for params files for link
commands. As part of this we're removing support for arguments with
leading @s. This change should be a no-op.

Which issues(s) does this PR fix?

Compatibility with bazelbuild/bazel#12265

The macOS toolchain is gaining support for params files for link
commands. As part of this we're removing support for arguments with
leading `@`s. This change should be a no-op.

bazelbuild/bazel#12265
Copy link
Contributor

@jayconrod jayconrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jayconrod jayconrod merged commit 0908892 into bazelbuild:master Nov 9, 2020
@keith keith deleted the ks/install-name branch November 9, 2020 20:54
@keith
Copy link
Member Author

keith commented Nov 9, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants