Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go_binary: Emit CcInfo directly instead of using cc_{import,library} #2682

Closed
wants to merge 1 commit into from

Conversation

Yannic
Copy link
Contributor

@Yannic Yannic commented Oct 20, 2020

What type of PR is this?

Uncomment one line below and remove others.

Bug fix
Feature
Documentation
Other

What does this PR do? Why is it needed?

Which issues(s) does this PR fix?

Fixes #

Other notes for review

@google-cla google-cla bot added the cla: yes label Oct 20, 2020
@Yannic
Copy link
Contributor Author

Yannic commented Oct 20, 2020

(context: Prototyping for bazelbuild/bazel#12304, which breaks cgo)

@fmeum
Copy link
Collaborator

fmeum commented Nov 24, 2022

@Yannic It looks like rules_go is no longer relying on cc_import and cc_library. Is this PR still relevant?

@Yannic
Copy link
Contributor Author

Yannic commented Nov 24, 2022

Probably not then

@Yannic Yannic closed this Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants