This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Use pusher based on go-containerregistry #481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddharthab
added a commit
to grailbio-external/rules_docker
that referenced
this pull request
Aug 9, 2018
This lets people get around the limitation of using the pusher from the python containerregistry, and can substitute with their own pusher. The main issue with the python containerregistry is that it uses python2 httplib2, and so workspaces using python3 as their interpreter can not depend on it successfully. See for instance, a pusher in go at bazelbuild#481.
siddharthab
added a commit
to grailbio-external/rules_docker
that referenced
this pull request
Aug 9, 2018
This lets people get around the limitation of using the pusher from the python containerregistry, and can substitute with their own pusher. The main issue with the python containerregistry is that it uses python2 httplib2, and so workspaces using python3 as their interpreter can not depend on it successfully. See for instance, a pusher in go at bazelbuild#481.
|
Would love to see this merge, frustrating to deal with on machines with |
|
I agree. Internally, we have exposed the pusher attribute on the rules and have been using the Go program. I can work on the PR more if I get some buy in from the repo owners. Puller and join_layers should also be very similar eliminating all httplib2 paths. |
|
Sorry for the delay getting back. I do agree that its an issue this cant run smoothly with Python3. |
|
Please see the PR that I sent (#490) that should provide a viable solution to avoid to have to make these large changes. |
siddharthab
added a commit
to grailbio-external/rules_docker
that referenced
this pull request
Feb 5, 2019
This lets people get around the limitation of using the pusher from the python containerregistry, and can substitute with their own pusher. The main issue with the python containerregistry is that it uses python2 httplib2, and so workspaces using python3 as their interpreter can not depend on it successfully. See for instance, a pusher in go at bazelbuild#481.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is merely to share work that I had to do for avoiding python2 code paths in containerregistry.
This will still need more work, namely
Happy to take it forward if people are interested.