Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container/bundle.bzl: improve bundle rules doc #1975

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

sluongng
Copy link
Contributor

@sluongng sluongng commented Dec 5, 2021

There was a concern raised in Bazelbuild Slack that the use case of
container_bundle is not clear to newer users.

Add the 2 known use cases of container_bundle to rule's doc.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

There was a concern raised in Bazelbuild Slack that the use case of
container_bundle is not clear to newer users.

Add the 2 known use cases of container_bundle to rule's doc.
Update generated markdown files
Copy link
Contributor

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@alexeagle alexeagle merged commit a7a00b6 into bazelbuild:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants