feat: add timeout attribute to container_pull #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @ptarjan |
|
Amazing! Thank you. Is there precident of which should win when both an attribute and environment variable are both specified? |
|
I don't know of a common pattern for this, it seems like the rule attribute should be more specific, but I could also see an argument that the environment is quicker to override than a code change so you'd want the environment variable to take precedence. |
|
Yeah I argued with myself that both ways had good reasons so was hoping
there was a precident. Alas.
…On Tue, Nov 16, 2021 at 10:04 PM Alex Eagle ***@***.***> wrote:
I don't know of a common pattern for this, it seems like the rule
attribute should be more specific, but I could also see an argument that
the environment is quicker to override than a code change so you'd want the
environment variable to take precedence.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1960 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAJZTZBU5HOYD3NTPXWFUDUMNAXPANCNFSM5IFVNQ3A>
.
|
The PULLER_TIMEOUT env variable is convenient, but one very large image shouldn't require that all of them have timeouts changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PULLER_TIMEOUT env variable is convenient, but one very large image shouldn't require that all of them have timeouts changed.