Fix path handling in archive.py to always be posix and not native paths #1892
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
No tests have been changed or added, but existing tests should validate the new behaviour still results in valid images
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
Currently, rules_docker when executed on windows will build a tar file with
\
characters in the tar, this works fine when opened with tools like 7z, however, when extracting using a typicaltar
tool (or when docker does it), the files end up mangled with <filename>` all jumbled up together in their file nameThis is because archive.py makes a lot of assumptions about posix paths using
/
characters, but then bundles this up with also usingos.path
instead ofposixpath
What is the new behavior?
This fixes this problem by using
posixpath
inarchive.py
Does this PR introduce a breaking change?
Other information
I realize windows support is spotty and partial at best, but this gets us going :)