Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arm64 support to load puller and loader binaries #1671

Merged
merged 2 commits into from
Nov 11, 2020
Merged

Add arm64 support to load puller and loader binaries #1671

merged 2 commits into from
Nov 11, 2020

Conversation

tcnghia
Copy link
Contributor

@tcnghia tcnghia commented Nov 5, 2020

Similar to what #1661 does for s390x.

@google-cla google-cla bot added the cla: yes label Nov 5, 2020
@tcnghia
Copy link
Contributor Author

tcnghia commented Nov 7, 2020

@cgdolan @smukherj1 can you please help review? thank you.

@cgdolan
Copy link
Contributor

cgdolan commented Nov 7, 2020

Hi Nghia - thanks so much for this change. I'm super excited for this to land, unfortunately I'm not an OWNER so I am unable to review this change.

@DaveGay
Copy link
Collaborator

DaveGay commented Nov 9, 2020

/gcbrun

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaveGay, tcnghia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DaveGay
Copy link
Collaborator

DaveGay commented Nov 9, 2020

Please fix the buildkite formatting issue.

(Download buildifier 0.22.0 and run: buildifier container/load.bzl repositories/repositories.bzl )

@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 9, 2020
@k8s-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@tcnghia
Copy link
Contributor Author

tcnghia commented Nov 9, 2020

Please fix the buildkite formatting issue.

(Download buildifier 0.22.0 and run: buildifier container/load.bzl repositories/repositories.bzl )

@DaveGay Done. Thanks!

@DaveGay
Copy link
Collaborator

DaveGay commented Nov 10, 2020

/gcbrun

@tcnghia tcnghia mentioned this pull request Nov 10, 2020
Closed
@tcnghia
Copy link
Contributor Author

tcnghia commented Nov 11, 2020

@DaveGay it seems the CI run is stuck (waiting for status for more than a day now). I wonder if this is just a workflow issue or does it indicate some problem with the change?

@DaveGay
Copy link
Collaborator

DaveGay commented Nov 11, 2020

/gcbrun

@DaveGay DaveGay merged commit e290d09 into bazelbuild:master Nov 11, 2020
@DaveGay
Copy link
Collaborator

DaveGay commented Nov 11, 2020

@tcnghia Looks like the check passed but the notification got lost. Merged, and thanks!

@tcnghia tcnghia mentioned this pull request Nov 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveGay DaveGay DaveGay approved these changes

@eytankidron eytankidron Awaiting requested review from eytankidron

@smukherj1 smukherj1 Awaiting requested review from smukherj1 smukherj1 is a code owner

Assignees

@tcnghia tcnghia

@DaveGay DaveGay

Labels
approved cla: yes size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tcnghia @cgdolan @DaveGay @k8s-ci-robot