This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Update go-containerregistry to pull in tarball foreign layer support #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: 1. --format arg dictates the format of the generated manifest to be pushed to the remote registry instead of the format of the incoming image. 2. Simply the image source argument from overloading the "--src" flag to having separate flags for config & tarball files.
Refactored the pusher, digester, flattener & join_layers binaries to use all available layer parts to serve the layer digest & diffIDs. The previous implementation would read the entire layer and actually compute the digest instead of using the pre-computed digests. Refactor the Starlark argument & input processing code for an image stored in the intermediate format into a single function and reused this function to provide the arguments to all the Go binaries.
Added a test for the base where the base image is derived from a tarball.
Also updating storing references to images as name.Tag to name.Reference because that's what the latest version of go-containerregistry requires.
|
/gcbrun |
nlopezgi
approved these changes
Sep 6, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nlopezgi, smukherj1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the
name.Tagtoname.Referencein maps from image names to images to conform to the new go-containerregistry API.Added a test to ensure the manifest in the image tarball generated by the Go join_layers includes the foreign layer URL.