This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Migrate rules_docker to go-containerregistry #1114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smukherj1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@googlebot rescan |
smukherj1
force-pushed
the
go_migration
branch
from
4c64802
to
bdb46fa
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #1111 and includes the changes from that PR. This PR is intended to complete the planned migration in #580. I'm creating this now to figure out the impact on our internal repo and incrementally update our tests on Github because the image digests are expected to change.
Changes included so far:
Alias container_(pull|push) to new_container_(pull|push).
Switch the config creator & digester to the Go implementation.
Make the --format argument in the new pusher & digester backwards compatible with the python implementation. This fixes #1075 and #927.
TODO:
Expecting most tests that compare digests are going to fail. The digest is expected to change because the Go manifest is formatted differently. Will update all the tests in future commits.