Allow extra args to cc_sysroot #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible for there to be some arguments that are naturally
associated with the sysroot flag, for example on macOS there are
associated framework search paths that should be added with
`-F{sysroot}/Library/Frameworks`. There are also warnings flags you
might want to add such as `-Werror=missing-sysroot`. In this case I
think it's nicer to provide them alongside the sysroot definition,
instead of having to create a custom cc_args for them.
comius
approved these changes
Oct 4, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 7, 2025
Imported changes from Github: - e278ee35e5ab56757bcd5ca3f10cab4822da1f1e Prepare release 0.7.2 (#258) by Alexandre Rostovtsev <arostovtsev@google.com> - bee95475e35903ac166766bc3df146d2acf4cbdb Remove apple_basic_test - we should not be accessing appl... by Alexandre Rostovtsev <arostovtsev@google.com> - aefab4cf8d6f46f1de97ae9e57fed9ba0648c3f1 fix: add missing proto_library load to support Bazel 8 (#... by Richard Levasseur <richardlev@gmail.com> - 91e429d9e2e959893c1ce2f81c35806b3a2daf8c Replace AppleDynamicFramework in test/testdata/apple_basi... by Philip Zembrod <pzembrod@gmail.com> - 46fd77a446f00faddedd0467ce993b462fba3c8a Delete usages/tests of the builtin bazel java symbols (#2... by hvadehra <hvadehra@gmail.com> - 2ac0981b7c35ff46cf66cc92467c37411c7bfacc Update proto and prepare release 0.7.1 (#239) by Alexandre Rostovtsev <arostovtsev@google.com> - 03eb7ce460e3aa54fee1f4fac8fa6bfc3d7294f2 Fix CI since --enable_workspace is now disabled by defaul... by Alexandre Rostovtsev <arostovtsev@google.com> - 2100c63ca234836bd600800587076860a6973918 Merge user-defined tags with default tags in stardoc macr... by yashathwani <145871056+yashathwani@users.noreply.github.com> - db47c15e8d342c5e5b95d81554d7f901ba062c2e Revert most of #237 and #238 (#243) by Alexandre Rostovtsev <arostovtsev@google.com> - 0ac26cd45b01011ffc172bd2054f07e9df1efbf2 Skip Bazel 7.2 tests in downstream pipeline (#244) by Alexandre Rostovtsev <arostovtsev@google.com> - da374a508b5a5f82e1e00f94889f04f9f86ca1fe Fix internal linter warnings (#235) by Alexandre Rostovtsev <arostovtsev@google.com> - c026daeee09fb072a02be87dfc87ea60d157e770 Improve incompatible flag testing (#238) by Alexandre Rostovtsev <arostovtsev@google.com> - 7f0601624ceb55c84690ba9fc86a097a4c7cf6b8 Make Stardoc work with --incompatible_enable_proto_toolch... by lberki <lberki@users.noreply.github.com> - 00cc953512de26265c2c9b86947b5b13f338d707 Prepare release 0.7.0 (#233) by Alexandre Rostovtsev <arostovtsev@google.com> - 1be7db63c28825a147670fe68d223633e37c8141 Do not emit rules_pkg dep in distro tarball's MODULE.baze... by Alexandre Rostovtsev <arostovtsev@google.com> - 92a4819c07f0985aba3746a5d89b81b6a4adf194 Respect --stamp and --nostamp flags for stamping (#234) by Alexandre Rostovtsev <arostovtsev@google.com> - 018dee5bd296d81fa3f1eff3a08512d190ff7181 Include `load` in summaries (#216) by Fabian Meumertzheim <fabian@meumertzhe.im> - aba1a01295094e9df40fc94e355f54e7e98dcd33 Update test regeneration script to support multiple Bazel... by Alexandre Rostovtsev <arostovtsev@google.com> - f39ed53f56f2de895b2f1891fa166b2b3b0e3fe7 Render *args / * / **kwargs properly in function summary ... by Alexandre Rostovtsev <arostovtsev@google.com> - f40819fd48193987f8cd22d724fbbab2a7aaf322 Refactor param rendering in summary line (#230) by Alexandre Rostovtsev <arostovtsev@google.com> - 4644386b36253da4436bb961ed1f5fbcc8c15101 proto_format_test requires Bazel 7.1, and may break with ... by Alexandre Rostovtsev <arostovtsev@google.com> - 666b7ba7124b9af9c531c6c5f2013f69b27ea144 Render documentation for provider `init` callbacks (#224) by Alexandre Rostovtsev <arostovtsev@google.com> ... and update copybara configs and tests. BEGIN_PUBLIC Regenerate Starlark docs using Stardoc 0.7.2. END_PUBLIC PiperOrigin-RevId: 713040596 Change-Id: Id84f0010b5c873041c30880d7b47ac6e5eaa5c74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for there to be some arguments that are naturally associated with the sysroot flag, for example on macOS there are associated framework search paths that should be added with
-F{sysroot}/Library/Frameworks. There are also warnings flags you might want to add such as-Werror=missing-sysroot. In this case I think it's nicer to provide them alongside the sysroot definition, instead of having to create a custom cc_args for them.